Skip to content

Conversation

@sebastiansimson
Copy link
Contributor

No description provided.

@sebastiansimson sebastiansimson requested a review from wallin May 18, 2022 07:37
@wallin wallin requested a review from jstoup111 May 18, 2022 08:23
@sebastiansimson sebastiansimson requested a review from aalekz May 19, 2022 15:10
jstoup111
jstoup111 previously approved these changes May 19, 2022
Comment on lines +188 to +199
public String toString() {
StringBuilder sb = new StringBuilder();
sb.append("class Changeset {\n");
sb.append(" ").append(toIndentedString(super.toString())).append("\n");
sb.append(" password: ").append(toIndentedString(password)).append("\n");
sb.append(" email: ").append(toIndentedString(email)).append("\n");
sb.append(" phone: ").append(toIndentedString(phone)).append("\n");
sb.append(" authenticationMethodType: ").append(toIndentedString(authenticationMethodType)).append("\n");
sb.append(" name: ").append(toIndentedString(name)).append("\n");
sb.append("}");
return sb.toString();
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this class work considering the keys can be dynamic? I'm not seeing any code that sets the value correctly when there's a dynamic key.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It extends HashMap so I think that is how it handles it

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I don't see any code that sets the value of the hash, but maybe I'm missing it somewhere.

wallin
wallin previously approved these changes May 19, 2022
@sebastiansimson sebastiansimson dismissed stale reviews from wallin and jstoup111 via 60e7ac6 May 19, 2022 16:19
@sebastiansimson sebastiansimson force-pushed the feature/generated-models-for-risk-filter-log branch from 5f398ae to 7c18139 Compare May 20, 2022 07:42
@sebastiansimson sebastiansimson merged commit ce68b74 into master May 20, 2022
@sebastiansimson sebastiansimson deleted the feature/generated-models-for-risk-filter-log branch May 20, 2022 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants